-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear distance when save waypoint #34779
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-01-24.at.05.54.23.mp4Android: mWeb ChromeCleanShot.2024-01-24.at.05.52.37.mp4iOS: NativeCleanShot.2024-01-24.at.06.22.49.mp4iOS: mWeb SafariCleanShot.2024-01-24.at.06.10.02.mp4MacOS: Chrome / SafariCleanShot.2024-01-24.at.05.59.41.mp4MacOS: DesktopCleanShot.2024-01-24.at.06.41.00.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 Could you please add missing screenshots for IOS and IOS safari ?
@fedirjh i just added missing screenshots for IOS and IOS safari. Please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -73,6 +73,7 @@ function saveWaypoint(transactionID: string, index: string, waypoint: RecentWayp | |||
// Clear the existing route so that we don't show an old route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually sorry, can we update this comment or add a new one nearby explaining why we're clearing out distance
, just so it's easy to understand / remember why this is needed in the future? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added comment, please check again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @dukenv0307 - do you mind adding the comment to the distance: null
you added as well? Seems you added the comment to another place we set distance to null, which is also useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beamanator Thanks for your comment, please check again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha we must clear distance a lot -> You added distance: null
on line 76, but added comments on line 150 & 260 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omg, this is my mistake. I just added a comment to all distance: null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! Apparently we clear distance in many places hahaha now we both know!
@@ -73,6 +73,7 @@ function saveWaypoint(transactionID: string, index: string, waypoint: RecentWayp | |||
// Clear the existing route so that we don't show an old route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @dukenv0307 - do you mind adding the comment to the distance: null
you added as well? Seems you added the comment to another place we set distance to null, which is also useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @dukenv0307 !
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.33-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
Details
The amount does not change when user changes the finish point via the distance option from the confirmation page (without going back two times)
Fixed Issues
$ #34226
PROPOSAL: #34226 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios-mweb.mov
iOS: mWeb Safari
ios-mweb-resize.mp4
MacOS: Chrome / Safari
web-resize.mp4
MacOS: Desktop
desktop-resize.mp4